Add error callback for raw data

[dianatatu]

Need

Besides success callback, we need to have an error callback for errors in raw data.
This is currently needed in #7849 .

Solution

• add erorr callback that triggers an error event.

Files changed

• thehole/app/core/raw_data.coffee

cc @aismail

[dianatatu]

@aismail please review :)

[ovidiuch]

This https://github.com/uberVU/mozaic/blob/master/core/libs/backbone/backbone-0.9.1.js#L323 is what we're trying to emulate from the Backbone model, right? This is the event triggered by the wrapError method it leads to: https://github.com/uberVU/mozaic/blob/master/core/libs/backbone/backbone-0.9.1.js#L1341 . Does the 'error', originalModel, resp, options event signature match yours 'error', @, @, xhr.status?

I don't think we should have "this" twice, here's an example of what we expect from the contents of the error event: https://github.com/uberVU/mozaic/blob/master/core/widget/backbone_events.coffee#L35-L45

Also, we use this instead of just @ now, when we don't have any leading property. E.g. trigger(this) or trigger(@property). You can replace it elsewhere in the file as well, if you want to do it

[dianatatu]

1. The call matches the trigger event signature
2. params[0] expects the model and params[1] the collection. I have changed the returned collection on error event to be the given collection if model has no collection
3. Thanks for the tip :) i've changed @ with this :)

[ovidiuch]

Done, LGTM. Some of us made changes on the thehole repo w/out syncing, and others viceversa. Either way, this one is all set now, after merging please run the sync_mozaic script again and create a pull request in thehole to update Mozaic in our repo. Besides the constants.coffee file, all should be migrated back.