Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save subregions to json and reorganise IO. #158

Merged
merged 22 commits into from Jul 29, 2022
Merged

Save subregions to json and reorganise IO. #158

merged 22 commits into from Jul 29, 2022

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Jul 7, 2022

  • Save subregions to json file when saving a field
  • Load subregion information from json file (if it exists) when loading a field from disk
  • Move IO for df.Field to a separate submodule
  • Use pathlib.Path for io

@lang-m lang-m changed the title Save subregions to json. Save subregions to json and reorganise IO. Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #158 (63f7859) into master (7b8019d) will decrease coverage by 0.10%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   95.86%   95.76%   -0.11%     
==========================================
  Files          22       27       +5     
  Lines        2371     2433      +62     
==========================================
+ Hits         2273     2330      +57     
- Misses         98      103       +5     
Impacted Files Coverage Δ
discretisedfield/io/ovf2vtk.py 100.00% <ø> (ø)
discretisedfield/util/__init__.py 100.00% <ø> (ø)
discretisedfield/util/util.py 81.57% <ø> (-6.04%) ⬇️
discretisedfield/io/util.py 58.33% <58.33%> (ø)
discretisedfield/io/ovf.py 99.08% <99.08%> (ø)
discretisedfield/field.py 96.98% <100.00%> (-0.50%) ⬇️
discretisedfield/io/__init__.py 100.00% <100.00%> (ø)
discretisedfield/io/hdf5.py 100.00% <100.00%> (ø)
discretisedfield/io/vtk.py 100.00% <100.00%> (ø)
discretisedfield/mesh.py 99.36% <100.00%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8019d...63f7859. Read the comment docs.

@lang-m lang-m requested a review from swapneelap July 14, 2022 10:39
Copy link
Member

@swapneelap swapneelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments. Everything else looks good to me.

discretisedfield/field.py Show resolved Hide resolved
discretisedfield/tests/test_field.py Outdated Show resolved Hide resolved
@lang-m lang-m merged commit 49eff5b into master Jul 29, 2022
@lang-m lang-m deleted the save-subregions branch July 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants