Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise Drive object #22

Merged
merged 23 commits into from May 19, 2022
Merged

Generalise Drive object #22

merged 23 commits into from May 19, 2022

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented May 18, 2022

  • new classes AbstractDrive and CombinedDrive
  • __shift__ to concatenate multiple drives (returns a CombinedDrive)

@lang-m lang-m requested a review from marijanbeg May 18, 2022 16:29
marijanbeg
marijanbeg reviewed May 18, 2022
View reviewed changes
Copy link
Member

@marijanbeg marijanbeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

micromagneticdata/abstract_drive.py Outdated Show resolved Hide resolved
micromagneticdata/abstract_drive.py Outdated Show resolved Hide resolved
micromagneticdata/combined_drive.py Show resolved Hide resolved
micromagneticdata/combined_drive.py Show resolved Hide resolved
micromagneticdata/combined_drive.py Outdated Show resolved Hide resolved
micromagneticdata/combined_drive.py Show resolved Hide resolved
micromagneticdata/combined_drive.py Outdated Show resolved Hide resolved
micromagneticdata/tests/test_combined_drive.py Outdated Show resolved Hide resolved
micromagneticdata/tests/test_combined_drive.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022 •
edited

Codecov Report

Merging #22 (7665d7d) into master (a77342d) will increase coverage by 2.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   97.43%   99.45%   +2.02%     
==========================================
  Files           3        5       +2     
  Lines         117      185      +68     
==========================================
+ Hits          114      184      +70     
+ Misses          3        1       -2
Impacted Files Coverage Δ
micromagneticdata/__init__.py 100.00% <100.00%> (ø)
micromagneticdata/abstract_drive.py 100.00% <100.00%> (ø)
micromagneticdata/combined_drive.py 100.00% <100.00%> (ø)
micromagneticdata/drive.py 98.14% <100.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77342d...7665d7d. Read the comment docs.

marijanbeg
marijanbeg approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@marijanbeg marijanbeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

micromagneticdata/combined_drive.py Outdated Show resolved Hide resolved
@lang-m lang-m merged commit 29f13a4 into master May 19, 2022
@lang-m lang-m deleted the drive-generalisation branch May 19, 2022 16:58
@lang-m lang-m mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marijanbeg marijanbeg marijanbeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lang-m @codecov-commenter @marijanbeg