Add a test for new Hsteps keyword argument
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test structure of new `TestHysteresisDriver` class is now similar to already existing `TestMinDriver` class.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 14 14
=========================================
Hits 14 14 ☔ View full report in Codecov by Sentry. |
We plan to completely switch to using fixtures and simple test functions instead of test classes with setup/teardown methods
for more information, see https://pre-commit.ci
|
@newton-per-sqm I have reverted the structure to simple functions (instead of the class) and added additional fixtures to avoid duplication. |
samjrholt
approved these changes
Jan 24, 2024
|
We should wait with merging until ubermag/oommfc#151 is merged. |
lang-m
added a commit
to ubermag/mumax3c
that referenced
this pull request
May 9, 2024
Skip new hysteresis test from ubermag/micromagnetictests#46
This was referenced May 9, 2024
samjrholt
reviewed
May 9, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a necessary new test for PR ubermag/oommfc#138 (Adding Hsteps as new keyword argument to HysteresisDriver for stepped hysteresis loops).
Test structure of new
TestHysteresisDriverclass is now (again) similar to already existingTestMinDriverclass.Just a draft idea, if you want to, we could also just write a second function. IMHO the class structure is nicer.