Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run conda tests for all notebooks #159

Merged
merged 14 commits into from
Oct 6, 2023
Merged

Run conda tests for all notebooks #159

merged 14 commits into from
Oct 6, 2023

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Oct 4, 2023

No description provided.

@lang-m
tests: clone notebooks from discretisedfield
4f3998d
@lang-m
fix: remove debug tree (not available on mac or windows)
ff57227 
functionality not required in the long term; I checked the list of visible files
on Ubuntu in the first run
@lang-m lang-m linked an issue Oct 4, 2023 that may be closed by this pull request
Remove duplicated tests #155
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53c271d) 36.36% compared to head (15eeedf) 36.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   36.36%   36.36%           
=======================================
  Files           2        2           
  Lines          22       22           
=======================================
  Hits            8        8           
  Misses         14       14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lang-m
Copy link
Member Author

lang-m commented Oct 4, 2023

This could replace the conda workflows in the individual repositories.
Here is an example run for just the notebooks: https://github.com/ubermag/ubermag/actions/runs/6409812343/job/17401797080 (which we can't see otherwise because tests of the old release fail due to the xarray problem before we make it to the notebooks).

@lang-m lang-m marked this pull request as ready for review October 4, 2023 18:15
@lang-m lang-m requested a review from samjrholt October 4, 2023 18:15
samjrholt
samjrholt requested changes Oct 4, 2023
View reviewed changes
.github/workflows/conda.yml Outdated Show resolved Hide resolved
@lang-m @samjrholt
Update .github/workflows/conda.yml
231e478 
Co-authored-by: Sam Holt <48217392+samjrholt@users.noreply.github.com>
@lang-m lang-m merged commit be94407 into master Oct 6, 2023
4 of 16 checks passed
@lang-m lang-m deleted the check-all-notebooks branch October 6, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjrholt samjrholt samjrholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicated tests
3 participants
@lang-m @codecov-commenter @samjrholt