Remove implicit download in vm_setup, and add the option to download default image in HostNexus #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
changed the title
pykello
force-pushed
the
pykello/auto_images
branch
from
7ec8736
to
d1143d8
Compare
pykello
changed the title
pykello
force-pushed
the
pykello/auto_images
branch
2 times, most recently
from
7b494ec
to
a295c14
Compare
pykello
changed the title
fdr
reviewed
May 14, 2024
fdr
reviewed
May 14, 2024
fdr
approved these changes
May 14, 2024
enescakir
reviewed
May 15, 2024
enescakir
reviewed
May 15, 2024
pykello
force-pushed
the
pykello/auto_images
branch
from
a295c14
to
c0d3613
Compare
This is mostly a convenience for developers who always provision VMs
after setting up a host. Without this, they'll need to manually do an
image download after host setup is done. To use this, one needs to do:
```
> HostNexus.assemble(....,
default_boot_images: ["ubuntu-jammy", "github-ubuntu-2204"])
```
pykello
force-pushed
the
pykello/auto_images
branch
from
c0d3613
to
d6d7783
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove image download from vm_setup
DownloadBootImage is now how we manage image downloads, so we can remove implicit image download from here.
See #1526
Add the option to download the default images on host setup
This is mostly a convenience for developers who always provision VMs after setting up a host. Without this, they'll need to manually do an image download after host setup is done. To use this, one needs to do: