Hop to the correct label when reboot is requested. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/reboot
branch
from
d91b827
to
94ccd89
Compare
In #674 we changed the label which initiated reboot from `reboot` to `prep_reboot`. We do reboot in 2 cases: 1. When setting up host 2. On VmHost.incr_reboot We had updated the label to be hopped at for case 1, but we had missed updating the label for case 2. This PR fixes that. To initiate reboot, you can do `vm_host.incr_reboot`.
pykello
force-pushed
the
pykello/reboot
branch
from
94ccd89
to
37060c5
Compare
enescakir
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #674 we changed the label which initiated reboot from
reboottoprep_reboot. We do reboot in 2 cases:We had updated the label to be hopped at for case 1, but we had missed updating the label for case 2. This PR fixes that.
To initiate reboot, you can do
vm_host.incr_reboot.