chore: 🤖 upgrade markuplint #30
Merged
+1,153
−2,027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodai3
commented
Mar 18, 2024
| @@ -60,7 +60,7 @@ export const Nested: Story = { | |||
|
|
|||
| export const MarkupAsList: Story = { | |||
| render: (args) => ( | |||
| <Stack {...args} as="li"> | |||
| <Stack {...args} as="ul"> | |||
There was a problem hiding this comment.
This is not related to the switch component issue, but it came up upgrading markuplint major version.
kodai3
force-pushed
the
chore-update-markuplint
branch
from
26f3fbb
to
100a0f7
Compare
|
Leave this PR unmerged. |
to fix the workaround I introduced here ubie-oss#18 (comment) Signed-off-by: kodai3 <k3dai.su3@gmail.com>
Signed-off-by: kodai3 <k3dai.su3@gmail.com>
kodai3
force-pushed
the
chore-update-markuplint
branch
from
9dedb48
to
4ea4b40
Compare
|
@takanorip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the workaround I introduced here, because it is fixed with this. 🎉
This PR is to make sure it is fixed without degradation, I'll leave it up to you if you merge even alpha version. 👍