feat(story): set default view for globe #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumdumpling
requested changes
Nov 14, 2019
| useEffect(() => { | ||
| if (slide && slide.flyTo) { | ||
| dispatch(setFlyToAction(slide.flyTo)); | ||
| } | ||
| }, [dispatch, slide]); | ||
| if (slide && !slide.flyTo) { | ||
| dispatch(setFlyToAction(defaultView)); |
There was a problem hiding this comment.
You don't need a second if condition here if you just write:
dispatch(setFlyToAction(slide.flyTo || defaultView));
| if (slide && !slide.flyTo) { | ||
| dispatch(setFlyToAction(defaultView)); | ||
| } | ||
| }, [dispatch, slide, defaultView]); |
There was a problem hiding this comment.
I guess the defaultView was added automatically here!? It doesn't make much sense here since it will never change, but never mind.
There was a problem hiding this comment.
Yes, it's from our hooks checker plugin. It throws an error/warning if it's not added there.
There was a problem hiding this comment.
I thought so. The hooks plugin is... improvable... 😐🤷♀
plumdumpling
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #190