feat(imageType): set image types to change object fit #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Mar 17, 2021
| @@ -118,7 +122,14 @@ const StoryMedia: FunctionComponent<Props> = ({ | |||
| key={index} | |||
| style={{width: `${imageWidth}%`}}> | |||
| <div className={styles.imageContainer}> | |||
| <img className={styles.photo} src={imageUrl} /> | |||
| <img | |||
There was a problem hiding this comment.
The story gallery component is getting really big. Could you clean it up by pulling out a StoryGalleryImage component with captions for example
src/scripts/types/image-type.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| export enum ImageType { | |||
| Photo = 'photo', | |||
| Chart = 'chart' | |||
There was a problem hiding this comment.
Chart is probably not the best type here. It could be any other image which should be contained. Why not call it what it is like 'contain' and 'cover'?
There was a problem hiding this comment.
Sure, i can change it. I just thought contain and cover would be a bit confusing in the story mapper.
There was a problem hiding this comment.
Yes good point, but I guess labeling a photograph as "chart" just to display it as contained is more confusing. At least for me 😄
pwambach
suggested changes
Mar 17, 2021
| }}> | ||
| {images.map((image, index) => { | ||
| const imageCaption = imageCaptions?.find((_, i) => i === index); | ||
| const imageType = imageFits?.find((_, i) => i === index); |
pwambach
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #856