Frontend Translations #7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phpunit tests don't run on my machine. I believe it has to do with my setup of php version etc. I get the same errors with the main branch. Since I only made changes in the frontend I would ignore it for now.
Concerning the frontend:
npm run unittest
is green except for one test:
test/vue_unittest/basicComponents/CreateContributionModal.test.js:112
expect(CreateWizardExtend.stepvalue).to.deep.equal({headline: "", text: ""});
The object actually has two more items in it. I don't know where it comes from... I don't think it has to do with my changes.
In order to merge this to main the tests probably have to be all green though because there is a check before merge.