Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No results on react 14/15 (geosuggest v2.9.0) #405

Closed
WindRider7 opened this issue Oct 23, 2018 · 1 comment
Closed

No results on react 14/15 (geosuggest v2.9.0) #405

WindRider7 opened this issue Oct 23, 2018 · 1 comment
Labels
bug help wanted

Comments

@WindRider7
Copy link

WindRider7 commented Oct 23, 2018 •
edited

Short description

I was trying to search for some addresses, but could not find any.

Expected results

To see search results or error about my daily quota in console.

Actual results

I don't see google search results (only fixtures).

Reproduction steps

  1. Use react (and react-dom) version 14 or 15
  2. Add <Geosuggest /> class and provide API key
  3. Type some address in search box
  4. See no results displayed

Additional Information

I tested with react version 14 and 15 with react-geosuggest v2.9.0 I had no results.
I tried react-geosuggest v2.8.0 everything seem to be working.

Example: https://codesandbox.io/s/p5ym062qox
@ro-ka
Copy link
Contributor

ro-ka commented Oct 25, 2018

Thanks for reporting! If anyone wants to dig into this, feel free!

f8k8 added a commit to f8k8/react-geosuggest that referenced this issue Oct 25, 2018
@f8k8
fix(compatibility): change react and reactdom to peer dependencies
60abe1d 
React changed the way setState callbacks are handled in
version 16. When using react-geosuggest with React < 16
the callbacks were no longer called. In order to maintain
compatibility with React 0.14 and 15, React and ReactDOM
have been moved to peer dependencies.

Closes ubilabs#405
@f8k8 f8k8 mentioned this issue Oct 25, 2018
Merged
4 tasks
@ro-ka ro-ka closed this as completed in b4a8b40 Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ro-ka @WindRider7