feat: save permits to database #20
Conversation
…ave-permits-to-db
| if (!locationData) { | ||
| const issueItem = await getRepo(parseGitHubUrl(issue.issueUrl)); | ||
| const { data: newLocationData, error } = await this._supabase | ||
| .from("locations") |
There was a problem hiding this comment.
@gentlementlegen Isn't the locations table deprecated? Shouldn't we just delete it or at least don't use at all?
There was a problem hiding this comment.
Yeah we should probably stop using that table and instead just add a new URL column wherever it makes sense in the other tables.
There was a problem hiding this comment.
Used it because it is still there and we didn't update it to something different but indeed it should be changed. Might wanna have a different task for this so we can also migrate all the current values as well (there are 43 records)
There was a problem hiding this comment.
Don't worry about data migrations. Basically none of the old data is valuable. No need to do extra work to save it.
|
I also did a review. The error handling looks good, after tests are fixed can be merged. |
Resolves #13