Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/angular 2 upgrade #140

Merged
merged 23 commits into from Nov 21, 2016
Merged

Chore/angular 2 upgrade #140

merged 23 commits into from Nov 21, 2016

Conversation

zakhenry
Copy link
Member

@zakhenry zakhenry commented Nov 14, 2016

This project uses semver, please check the scope of this pr:

  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

@@ -49,10 +47,10 @@
"@types/proxyquire": "^1.3.26",
"@types/socket.io": "^1.4.26",
"@types/validator": "^4.5.26",
"@xiphiaz/vantage": "^1.7.2",
"angular2-universal": "^2.1.0-rc.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

export * from './browser';
export * from './common';
export * from './server';
// export * from './browser';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@@ -36,3 +37,17 @@ export const CORE_PROVIDERS: ProviderDefinition[] = [
{provide: Server, useClass: ExpressServer},
{provide: Logger, useClass: ConsoleLogger},
];

//
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -14,6 +12,9 @@ import { ExpressServer } from './servers/express.server';
import * as dotenv from 'dotenv';
import * as path from 'path';
import * as _ from 'lodash';
// import { ProviderDefinition } from './bootstrap/bootstrap';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

import { RemoteCliMock } from './remoteCli.service.mock';
import { AuthServiceMock } from './auth.service.mock';
import { AuthService } from './auth.service';
import * as chalk from 'chalk';

import Spy = jasmine.Spy;

describe('Remote CLI Commands', () => {
xdescribe('Remote CLI Commands', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

import alias = require('~vantage/index');
export = alias;
}
declare module 'vantage'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move into src/server/services/remoteCli.service.ts

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ba28d05 on chore/angular-2-upgrade into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6608432 on chore/angular-2-upgrade into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 663aaed on chore/angular-2-upgrade into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ab3b9c7 on chore/angular-2-upgrade into * on master*.

@zakhenry zakhenry merged commit 55734c3 into master Nov 21, 2016
@zakhenry zakhenry deleted the chore/angular-2-upgrade branch November 21, 2016 23:51
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d8ecda1 on chore/angular-2-upgrade into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants