Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove rewards app, update permit types #6

Merged
merged 1 commit into from Mar 4, 2024
Merged

chore: remove rewards app, update permit types #6

merged 1 commit into from Mar 4, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Mar 3, 2024

Related to ubiquity/pay.ubq.fi#185

  • removed unused rewards app js kept the css
  • moved over the shared abis folder
  • copy/pasted the updated permit types and replaced TxData
  • the type Permit that should be generated from the DB schema still exists in audit.ts

@ubiquibot-continuous-deploys
Copy link

@molecula451
Copy link
Member

looking good, would help some testing at https://f9286cfc.audit-ubq-fi.pages.dev/

molecula451
molecula451 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitcoindev is fixing knip, tho

gitcoindev
gitcoindev approved these changes Mar 4, 2024
View reviewed changes
Copy link

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let's skip Knip CI failures till fixed this week.

.cspell.json Show resolved Hide resolved
@molecula451 molecula451 merged commit 4181d26 into ubiquity:development Mar 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molecula451 molecula451 molecula451 approved these changes

@gitcoindev gitcoindev gitcoindev approved these changes

@rndquu rndquu rndquu approved these changes

@gentlementlegen gentlementlegen Awaiting requested review from gentlementlegen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Keyrxng @molecula451 @gitcoindev @rndquu