Fix nonce validation error

[barebind]

Resolves #149

Fix nonce validation error by mimicking the original solidity code.

[ubiquibot]

40bfcaf

[rndquu]

@barebind Did you try that the code works as expected?

[barebind]

@rndquu yes I've tested multiple cases. used/non-used nonces, connected wallets etc.

one thing though, if you try to test, the generate-permit2-url.ts script doesn't work in the development branch. I've fixed that too but didn't commit because it's already committed in another PR

[rndquu]

yes I've tested multiple cases. used/non-used nonces, connected wallets etc.

I'm asking because (as far as I remember) this is the correct implementation of checking whether nonce is valid. Current PR introduces the xor operation which doesn't exist here.

one thing though, if you try to test, the generate-permit2-url.ts script doesn't work in the development branch

It's kind of obsolete, could be removed but it's a useful reference.

I've fixed that too but didn't commit because it's already committed in another #151

Overall pls follow the "1 PR solves exactly 1 issue rule", otherwise it's really hard to review PRs

[barebind]

I've implemented/mimicked from the solidity code which has exactly same functionality actually. Current implementation (also the one that you referenced) never worked as expected for me on my local.

Overall pls follow the "1 PR solves exactly 1 issue rule", otherwise it's really hard to review PRs

Sure.

[gitcoindev]

All right this is in line with my discovery. ubiquity/ubiquibot-kernel#5 (comment) , the change looks good and I am also approving from my side.