-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nonce validation error #152
Fix nonce validation error #152
Conversation
@barebind Did you try that the code works as expected? |
@rndquu yes I've tested multiple cases. used/non-used nonces, connected wallets etc. one thing though, if you try to test, the generate-permit2-url.ts script doesn't work in the |
I'm asking because (as far as I remember) this is the correct implementation of checking whether nonce is valid. Current PR introduces the
It's kind of obsolete, could be removed but it's a useful reference.
Overall pls follow the "1 PR solves exactly 1 issue rule", otherwise it's really hard to review PRs |
I've implemented/mimicked from the solidity code which has exactly same functionality actually. Current implementation (also the one that you referenced) never worked as expected for me on my local.
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right this is in line with my discovery. ubiquity/ubiquibot-kernel#5 (comment) , the change looks good and I am also approving from my side.
Resolves #149
Fix nonce validation error by mimicking the original solidity code.