Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Paid Label to Permitted #253

Closed
0x4007 opened this issue Apr 11, 2023 · 8 comments · Fixed by #301
Closed

Rename Paid Label to Permitted #253

0x4007 opened this issue Apr 11, 2023 · 8 comments · Fixed by #301

Comments

@0x4007
Copy link
Member

0x4007 commented Apr 11, 2023

The intent is to tag the issue (for filtering purposes) that a payment permit has already been generated for the issue. I'm honestly still not a fan of this approach at all but it seems that the team is skeptical about rate limit overhead. So for now we will leave this feature in.

We need to rename from Paid to Permitted because Paid is misleading.

          @Steveantor this `Paid` label is a feature that I'm not aware of. I disagree with this approach because @rndquu already implemented cross referencing permits with etherescan transactions to actually verify that the payment has been made. I presume that you are simply adding the label "Paid" when it writes the permit which is misleading, because it doesn't actually check that the payment was made. 

Originally posted by @pavlovcik in #158 (comment)

@0x4007
Copy link
Member Author

0x4007 commented Apr 11, 2023

@0x4007 0x4007 changed the title Remove Rogue Paid Label Rename Paid Label to Payment Authorized May 1, 2023
@0x4007 0x4007 changed the title Rename Paid Label to Payment Authorized Rename Paid Label to Permit Authorized May 1, 2023
@Steveantor
Copy link
Contributor

Permit Authorized is too verbose, it's Paid in the sense that we've generated the permit aka Paid,
now it's the bounty hunter's responsibility to claim those when is up to them.

@0x4007 0x4007 changed the title Rename Paid Label to Permit Authorized Rename Paid Label to Permitted May 7, 2023
@seprintour
Copy link
Contributor

seprintour commented May 14, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented May 14, 2023

@seprintour The time limit for this bounty is on Sun, 14 May 2023 19:50:18 GMT

Your currently set address is:
0x3623338046b101ecEc741De9C3594CC2176f39E5
please use /wallet 0x4FDE...BA18 if you want to update it.

@Steveantor
Copy link
Contributor

/assign

It was still on the discussion

@0x4007
Copy link
Member Author

0x4007 commented May 15, 2023

It was still on the discussion

The conclusion I came to is simply renaming Paid to Permitted! Regardless, technically because there was a price set on this issue its up for grabs no matter the current state of the bounty (it is our responsibility to not set prices for incomplete bounties for example.)

Ideally I would like to remove this label all together but it seems like the team decided that it is not feasible to do due to rate limiting?

@ubiquibot
Copy link

ubiquibot bot commented May 15, 2023

[ CLAIM 50 DAI ]

0x3623338...76f39E5

@ubiquibot ubiquibot bot added the Paid label May 15, 2023
@Draeieg
Copy link
Contributor

Draeieg commented May 29, 2023

we can use "Paid" the same way and "Claimed" when the hunter gets his money

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants