Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max bounty hunter issues improvement #298

Closed
0x4007 opened this issue May 10, 2023 · 4 comments · Fixed by #387
Closed

Max bounty hunter issues improvement #298

0x4007 opened this issue May 10, 2023 · 4 comments · Fixed by #387

Comments

@0x4007
Copy link
Member

0x4007 commented May 10, 2023

An improvement idea is to check all of the open pull requests of the bounty hunter, and then check the state of the pull request review.

If they have a pull request open but no review started, then it counts against their quota.

If they have a pull request opened and also have a "review" in progress (perhaps there is an api to get a Boolean for this) then they are able to start working on another bounty.

Next level beyond could be a
one day "cool down". If there's longer than a 24 hour delay by the core team/reviewers, then "unlock" the bounty hunter to work on another issue.

Originally posted by @pavlovcik in #245 (comment)

@wannacfuture
Copy link
Contributor

wannacfuture commented Jun 8, 2023

Let's clarify.

If a bounty hunter has opened pull request with no review, then the value of available_bounty_hunter_issue will decrease.(the initial value of available_bounty_hunter_issue will be max_bounty_hunter_issue config).

However, if the bounty hunter has opened pull request with no review, but the pull request is created more than 24 hours ago, then the value of available_bounty_hunter_issue will increase.

When the bounty hunter assigns themselves to an issue, the bot will calculate their available_bounty_hunter_issue value. If this value is zero, the bot will add a comment saying: "You cannot assign yourself to this issue because you have other open pull requests.".

In conclusion, I need to calculate only opened PR numbers with no review which is created within 24hours before.

Am i right?

@wannacfuture
Copy link
Contributor

wannacfuture commented Jun 8, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Jun 8, 2023

@wannacfuture The time limit for this bounty is on Fri, 09 Jun 2023 18:49:43 GMT

Your currently set address is:
0x9e4EF4353C928cD3eb473E8f12aeCF58C208ef40
please use /wallet 0x4FDE...BA18 if you want to update it.

@ubiquibot
Copy link

ubiquibot bot commented Jun 13, 2023

[ CLAIM 150 WXDAI ]

0x9e4EF435...8C208ef40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Passed
2 participants