Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/max bounty issue improvement fixed #387

Conversation

wannacfuture
Copy link
Contributor

@wannacfuture wannacfuture commented Jun 9, 2023

Description

  • added feat: max bounty issue improvement(counts opened prs with no reviews)

closes #298

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit ca0ae35
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64834e65de0ad50008b66fd8
😎 Deploy Preview https://deploy-preview-387--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. You achieved the specification, thanks for that, but I think I will like to create a new bounty to make the 24 hour period configurable (this also means we need to add a new config property.

@wannacfuture
Copy link
Contributor Author

wannacfuture commented Jun 10, 2023

Code looks good. You achieved the specification, thanks for that, but I think I will like to create a new bounty to make the 24 hour period configurable (this also means we need to add a new config property.

Could you provide me detailed information? If you create another new bounty about it, I'll also handle it.

@0x4007
Copy link
Member

0x4007 commented Jun 12, 2023

If our new standard operating procedure is to request a QA test from @Draeieg then the last person to approve (@0xcodercrane) should request for a review from @Draeieg after the code checks out.

@0x4007 0x4007 requested a review from Draeieg June 12, 2023 14:06
@0x4007 0x4007 added this pull request to the merge queue Jun 12, 2023
@0x4007 0x4007 removed this pull request from the merge queue due to a manual request Jun 12, 2023
@wannacfuture
Copy link
Contributor Author

Seems your new standard operating procedure is too perfect.😅 @Draeieg , Could you review this PR?

@Draeieg
Copy link
Contributor

Draeieg commented Jun 13, 2023

Seems your new standard operating procedure is too perfect.😅 @Draeieg , Could you review this PR?

I need @0xcodercrane merge this to development in order to do my QA run

Also, we're going to implement #391, reducing the bureaucracy

@wannacfuture
Copy link
Contributor Author

Ah.. so, should I install QA app to my forked repo? And what should I do?
I can't get that meaning exactly. Could you explain in detail?

@Draeieg
Copy link
Contributor

Draeieg commented Jun 13, 2023

Ah.. so, should I install QA app to my forked repo? And what should I do?
I can't get that meaning exactly. Could you explain in detail?

The current plan is: Install the QA app on your forked repo, run the github action, and you should have the bot running with local changes

Then, open issues to test the code changes (by example in this case, you can open 3 assign to 2 then request for a review from yourself and then see if you can assign the third)

We're literally just releasing this, so if something sounds confusing or is not working, be sure to notify

@wannacfuture
Copy link
Contributor Author

wannacfuture commented Jun 13, 2023

Ah.. so, should I install QA app to my forked repo? And what should I do?
I can't get that meaning exactly. Could you explain in detail?

The current plan is: Install the QA app on your forked repo, run the github action, and you should have the bot running with local changes

Then, open issues to test the code changes (by example in this case, you can open 3 assign to 2 then request for a review from yourself and then see if you can assign the third)

We're literally just releasing this, so if something sounds confusing or is not working, be sure to notify

Actually, I have tested my PR on my local repository(not forked repo) and it worked. I installed QA app to that repository.

You can see the test result on https://github.com/wannacfuture/Battleship.
There, there are 4 issues and I assigned 3 issues even the maximum issue count is 2 because I have one Pull Request which is created over 24 hours before. And fourth assign was failed. It works correctly. @Draeieg , Could you review that one?

@0xcodercrane 0xcodercrane merged commit 7203cca into ubiquity:development Jun 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max bounty hunter issues improvement
5 participants