-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/max bounty issue improvement fixed #387
Feat/max bounty issue improvement fixed #387
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. You achieved the specification, thanks for that, but I think I will like to create a new bounty to make the 24 hour period configurable (this also means we need to add a new config property.
Could you provide me detailed information? If you create another new bounty about it, I'll also handle it. |
If our new standard operating procedure is to request a QA test from @Draeieg then the last person to approve (@0xcodercrane) should request for a review from @Draeieg after the code checks out. |
Seems your new standard operating procedure is too perfect.😅 @Draeieg , Could you review this PR? |
I need @0xcodercrane merge this to development in order to do my QA run Also, we're going to implement #391, reducing the bureaucracy |
Ah.. so, should I install QA app to my forked repo? And what should I do? |
The current plan is: Install the QA app on your forked repo, run the github action, and you should have the bot running with local changes Then, open issues to test the code changes (by example in this case, you can open 3 assign to 2 then request for a review from yourself and then see if you can assign the third) We're literally just releasing this, so if something sounds confusing or is not working, be sure to notify |
Actually, I have tested my PR on my local repository(not forked repo) and it worked. I installed QA app to that repository. You can see the test result on https://github.com/wannacfuture/Battleship. |
Description
closes #298