feat: read chain id from config #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
0x4007
reviewed
May 16, 2023
| @@ -22,7 +22,7 @@ export const DEFAULT_BOT_DELAY = 100; // 100ms | |||
| export const DEFAULT_FOLLOWUP_TIME = "4 days"; // 4 days | |||
| export const DEFAULT_DISQUALIFY_TIME = "7 days"; // 7 days | |||
|
|
|||
| export const DEFAULT_CHAIN_ID = 1; | |||
| export const DEFAULT_CHAIN_ID = 1; // ethereum | |||
| export const DEFAULT_RPC_ENDPOINT = "https://rpc-pay.ubq.fi/v1/mainnet"; | |||
There was a problem hiding this comment.
Suggested change
| export const DEFAULT_RPC_ENDPOINT = "https://rpc-pay.ubq.fi/v1/mainnet"; | |
| export const DEFAULT_RPC_ENDPOINT = "http://rpc-bot.ubq.fi/v1/mainnet"; |
Let's use rpc-bot.ubq.fi as a dedicated default endpoint for the bot! Also I'm pretty sure you need to use http not https.
There was a problem hiding this comment.
This is not part of the current issue. Pls check this PR #312
0x4007
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #283