-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI diamond hook #731
Comments
/start |
Skipping |
broken hook, unmaintainable, not really working with diamonds by defacto, a follow up from #710 |
Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment |
|
Releasing the bounty back to dev pool because the allocated duration already ended! |
Releasing the bounty back to dev pool because the allocated duration already ended! |
/start |
/help |
@molecula451 The time limit for this bounty is on Wed, 16 Aug 2023 18:45:04 UTC |
Tips:
|
Available commands
|
the diamond itself bring us the deployed contract addresses |
Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment |
@molecula451 - Releasing the bounty back to dev pool because the allocated duration already ended! |
Closing this as completed #771 |
Permit generation skipped since assignee is undefined If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you! |
Perhaps we should close as not complete? There isn't a merged pull request associated with this issue. |
Now there is one |
After implementing the diamond proxy in the contracts package most of our contracts (i.e. facets) have the same address (which basically equals to the deployed
Diamond
contract). The only exception (regarding the address) are the core contracts which should be deployed with the own upgrade mechanism because function names from the core contracts overlap with the ones in the facets and Diamond proxy doesn't support function clashing.So basically this code:
is the same as this one:
There is the react hook that returns all of the contract instances
We should take all of the facets and make sure that this hook returns all of the contract instances (i.e. facets) by a single diamond address
We can either refactor the existing hook or create a new one
This "return contracts" hook will be referenced in the next github issues (regarding the
dapp
package) where we will make sure, one by one, that all of the pages work fine with the diamond proxyThe text was updated successfully, but these errors were encountered: