Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI diamond hook #731

Closed
rndquu opened this issue Jul 11, 2023 · 19 comments · Fixed by #771
Closed

Add UI diamond hook #731

rndquu opened this issue Jul 11, 2023 · 19 comments · Fixed by #771
Labels
UI/UX UI development work is expected.

Comments

@rndquu
Copy link
Member

rndquu commented Jul 11, 2023

After implementing the diamond proxy in the contracts package most of our contracts (i.e. facets) have the same address (which basically equals to the deployed Diamond contract). The only exception (regarding the address) are the core contracts which should be deployed with the own upgrade mechanism because function names from the core contracts overlap with the ones in the facets and Diamond proxy doesn't support function clashing.

So basically this code:

const managerAddress = "0x4e037B9A8Ce977462DA4E10Fc164363C827abfc6";
const managerContract = await getUbiquityManagerContract(managerAddress, provider);

is the same as this one:

const diamondAddress = '0xbe0efAbc83686a81903C1D4a2515f8111e53B5Cb';
const managerContract = await getUbiquityManagerContract(diamondAddress, provider);

There is the react hook that returns all of the contract instances

We should take all of the facets and make sure that this hook returns all of the contract instances (i.e. facets) by a single diamond address

We can either refactor the existing hook or create a new one

This "return contracts" hook will be referenced in the next github issues (regarding the dapp package) where we will make sure, one by one, that all of the pages work fine with the diamond proxy

@rndquu rndquu added UI/UX UI development work is expected. Time: <1 Day labels Jul 11, 2023
@molecula451
Copy link
Member

molecula451 commented Jul 11, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Jul 11, 2023

Skipping /start since the issue is closed

@molecula451
Copy link
Member

molecula451 commented Jul 11, 2023

broken hook, unmaintainable, not really working with diamonds by defacto, a follow up from #710

@ubiquibot
Copy link

ubiquibot bot commented Jul 17, 2023

Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /unassign
Last activity time: Tue Jul 11 2023 11:23:13 GMT+0000 (Coordinated Universal Time)

@molecula451
Copy link
Member

Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /unassign Last activity time: Tue Jul 11 2023 11:23:13 GMT+0000 (Coordinated Universal Time)

#732

@ubiquibot
Copy link

ubiquibot bot commented Jul 27, 2023

Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Mon Jul 17 2023 08:58:13 GMT+0000 (Coordinated Universal Time)

@ubiquibot ubiquibot bot assigned molecula451 and unassigned molecula451 Jul 27, 2023
@ubiquibot
Copy link

ubiquibot bot commented Jul 27, 2023

Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Mon Jul 17 2023 08:58:13 GMT+0000 (Coordinated Universal Time)

@molecula451
Copy link
Member

/start

@molecula451 molecula451 self-assigned this Aug 15, 2023
@molecula451
Copy link
Member

/help

@ubiquibot
Copy link

ubiquibot bot commented Aug 15, 2023

@molecula451 The time limit for this bounty is on Wed, 16 Aug 2023 18:45:04 UTC

@ubiquibot
Copy link

ubiquibot bot commented Aug 15, 2023

Deadline Wed, 16 Aug 2023 18:48:36 UTC
Registered Wallet 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 15, 2023

    Available commands

    - /start: Assign the origin sender to the issue automatically.
    - /stop: Unassign the origin sender from the issue automatically.
    - /help: List all available commands.
    - /query: Comments the users multiplier and address
    - /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
      example usage: "/wallet @user 0.5 'Multiplier reason'"
    - /allow: Set access control. (Admin Only)
    - /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
      ex1: /wallet 0x0000000000000000000000000000000000000000
      ex2: /wallet vitalik.eth
    

    @molecula451
    Copy link
    Member

    the diamond itself bring us the deployed contract addresses

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 22, 2023

    Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Fri Aug 18 2023 21:46:14 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 23, 2023

    @molecula451 - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Tue Aug 15 2023 19:21:28 GMT+0000 (Coordinated Universal Time)

    @rndquu
    Copy link
    Member Author

    rndquu commented Aug 23, 2023

    Closing this as completed #771

    @rndquu rndquu closed this as completed Aug 23, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 23, 2023

    Permit generation skipped since assignee is undefined

    If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
    We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

    @0x4007
    Copy link
    Member

    0x4007 commented Aug 23, 2023

    Closing this as completed #771

    Perhaps we should close as not complete? There isn't a merged pull request associated with this issue.

    @rndquu
    Copy link
    Member Author

    rndquu commented Aug 23, 2023

    There isn't a merged pull request associated with this issue

    Now there is one

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    UI/UX UI development work is expected.
    Projects
    None yet
    3 participants