-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale problem raised by hard coded exception message in UnitTests #7
Comments
Can you elaborate on the exact problem here? The test code validates some exception messages explicitly generated by Llvm.NET library (not MScorlib or other framework libs) the reason is to ensure the correct handling of errors given invalid input. Since Most such cases ultimately generate an ArgumentException the tests need to delve into the exception a bit to verify that the correct information is provided to help a developer fix their usage of the API. At this point in time Llvm.NET itself uses hardcoded strings and not Locale specific resources for the exception messages. |
Tested in français France
Tested in 日本語
|
Ah, thanks for the clarification. I missed that would be checking strings owned by the platform. That's something that should be fixed in the tests. |
- This change simply alters the test for the exception message to verify the part provided by the Llvm.NET library itself, ignoring the trailing part provided by the BCL, which is subject to Locale differences. - Appveyor.yml is set to run test in a second locale to help catch any future issues.
https://stackoverflow.com/questions/209133/exception-messages-in-english
Though not a big problem if restricted to Appveyor environment. May cause trouble to local development.
The text was updated successfully, but these errors were encountered: