Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM8] New Opaque pointer handling incorrect #85

Closed
smaillet opened this issue May 3, 2019 · 0 comments
Closed

[LLVM8] New Opaque pointer handling incorrect #85

smaillet opened this issue May 3, 2019 · 0 comments
Labels
bug

Comments

@smaillet
Copy link
Member

smaillet commented May 3, 2019

Load (and others (like GEP) supporting the new opaue pointer concept with back-compat for typed pointers are incorrectly using the pointer type as the type pointer, however, it turns out, they should acully use the pointee type.
@smaillet smaillet added the bug label May 3, 2019
smaillet added a commit to smaillet/Llvm.NET that referenced this issue May 7, 2019
@smaillet
Fixes UbiquityDotNET#84,UbiquityDotNET#85,UbiquityDotNET#86
0912cfe 
- Deprecated InstructionBuilder.Load() single arg form, in favor of overload that accepts a type param for opaque pointers.
- Updated Analyzers to latest version and cleaned up code to correspond with changes in rules.
- Updated ANTLR4 version for Kaleidoscope Grammar.
- Added additional array marshaling info to the bindings generator to account for In arrays on some missed APIs
- Added ElementType to Alloca Instruction to provide a simple property to get the allocated type.
- Fixed GEP arg checks to validate args and indexes for arbitrary depth.
- Added SkipDocs switch to BuildAll.ps1 to allow faster inner loop development when doc builds aren't relevant.
smaillet added a commit that referenced this issue May 7, 2019
@smaillet
Fixes #84,#85,#86 (#87)
46ac111 
* Fixes #84,#85,#86
- Deprecated InstructionBuilder.Load() single arg form, in favor of overload that accepts a type param for opaque pointers.
- Updated Analyzers to latest version and cleaned up code to correspond with changes in rules.
- Updated ANTLR4 version for Kaleidoscope Grammar.
- Added additional array marshaling info to the bindings generator to account for In arrays on some missed APIs
- Added ElementType to Alloca Instruction to provide a simple property to get the allocated type.
- Fixed GEP arg checks to validate args and indexes for arbitrary depth.
- Added SkipDocs switch to BuildAll.ps1 to allow faster inner loop development when doc builds aren't relevant.

* Added additional arg checks to Context Construction
@smaillet smaillet closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smaillet