Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending POST request as HTML form #96

Merged
merged 1 commit into from Feb 1, 2018

Conversation

bystro
Copy link
Contributor

@bystro bystro commented Jan 27, 2018

Checkout the following approach.
I think scenarios I send request like a HTML from are more descriptive.

{
foreach ($files as $file) {
$this->restApiBrowser->addFileToRequest($file['name'], $file['path']);
if (!isset($element['object'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should go in Form object to be sure we use always Form in the right way.

@tyx
Copy link
Member

tyx commented Feb 1, 2018

Despite my comment, we can go with this PR ! Thank you very much.

I will go through some refinements in the next couple of days before release.

@tyx tyx merged commit 5421575 into ubirak:master Feb 1, 2018
@bystro
Copy link
Contributor Author

bystro commented Feb 1, 2018

Thank you Timothée.
We have to extend the implementation so that we could send multidimensional data like the bellow

<input type="text" name="options[0][deptid]" id="deptid" />
<input type="text" name="options[0][deptname]" id="deptname" />
<br/>
<input type="text" name="options[1][deptid]" id="deptid" />
<input type="text" name="options[1][deptname]" id="deptname" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants