Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up 1939 key registration #18

Merged
merged 4 commits into from Jun 30, 2020
Merged

Up 1939 key registration #18

merged 4 commits into from Jun 30, 2020

Conversation

leroxyl
Copy link
Contributor

@leroxyl leroxyl commented Jun 30, 2020

generate and register keys for known UUIDs at start

If you get a response code other than `200`, it means that something went wrong. You can check the error message if
you decode the `"response"`-UPP from the backend
If you get a response code other than `200`, it means that something went wrong. To check the error message,
decode the `"response"`-UPP from the backend using the [MessagePack to JSON Converter](https://toolslick.com/conversion/data/messagepack-to-json).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das wird bald nicht mehr gehen, da wir die response message nicht mehr ins upp packen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stimmt, aber ich würde es bis dann noch drin lassen und dann ein update machen, wenn das backend so weit ist.

Copy link
Contributor

@thinkberg thinkberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die CSRs hat jemand gecheckt, dass die korrekt sind?

@leroxyl leroxyl requested a review from gruenwaldi June 30, 2020 14:14
@leroxyl leroxyl assigned leroxyl and gruenwaldi and unassigned leroxyl Jun 30, 2020
@leroxyl leroxyl removed the request for review from gruenwaldi June 30, 2020 14:15
Copy link
Collaborator

@gruenwaldi gruenwaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@gruenwaldi gruenwaldi merged commit 1625595 into master Jun 30, 2020
@gruenwaldi gruenwaldi deleted the UP-1939-key-registration branch June 30, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants