Always add .cs files generated by text templating #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspelletier
reviewed
Jan 19, 2024
| // Always include files generated by text templating (.tt), even if they don't exist yet. | ||
| // These files are expected to be absent during a clean build, as they are generated | ||
| // during the build process. Therefore, they cannot be left out of the csproj file. | ||
| AddContentGeneratedItem(itemGroups, ttFile, generatedFile, generator, false, _projectPathCapitalized, project, true); |
There was a problem hiding this comment.
AddContentGeneratedItem is only use here. we should remove the last parameter.
There was a problem hiding this comment.
Removed the last parameter. Sorry for the long delay. Thanks for your attention!
jspelletier
reviewed
Feb 2, 2024
| @@ -0,0 +1,38 @@ | |||
| { | |||
There was a problem hiding this comment.
I think you need to rebase. We changed this in main branch.
|
please rebase. |
Always include files generated by text templating (.tt), even if they don't exist yet. These files are expected to be absent during a clean build, as they are generated during the build process. Therefore, they cannot be left out of the csproj file.
cmello
force-pushed
the
always_add_cs_files_generated_by_text_templating
branch
from
5d55c77
to
5ac0751
Compare
|
Rebased, thanks! |
|
merged. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always include files generated by text templating (.tt), even if they don't exist yet.
These files are expected to be absent during a clean build, as they are generated
during the build process. Therefore, they cannot be left out of the csproj file.