Support other http error codes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -451,6 +455,9 @@ private void closeConnectionDueToInternalServerError(RuntimeException exception) | |||
| private ByteBuffer generateHttpResponseDueToError(int errorCode) { | |||
| String errorCodeDescription; | |||
| switch (errorCode) { | |||
| case 401: | |||
| errorCodeDescription = "401 WebSocket Authentication Failure"; | |||
There was a problem hiding this comment.
I don't know if that is binding, but in OCPP 2.0.1, it says "HTTP/401 Authorization Required", so maybe the text should be "401 Authorization Required"?
There was a problem hiding this comment.
I think in the test it only checks error code but we can change it to be aligned with OCPP 2.0.1
| @@ -49,6 +51,17 @@ public InvalidDataException(int closecode) { | |||
| this.closecode = closecode; | |||
| } | |||
There was a problem hiding this comment.
This constructor should initialize httpErrorCode = null
| @@ -60,6 +73,19 @@ public InvalidDataException(int closecode, String s) { | |||
| this.closecode = closecode; | |||
| } | |||
There was a problem hiding this comment.
This constructor should initialize httpErrorCode = null
There was a problem hiding this comment.
It's not required as I used Integer so if not initialized it will be null
robert-s-ubi
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.