Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcow2-rs: don't enable direct-io on macos #2

Merged
merged 1 commit into from
Jan 15, 2024
Merged

qcow2-rs: don't enable direct-io on macos #2

merged 1 commit into from
Jan 15, 2024

Conversation

ming1
Copy link
Collaborator

@ming1 ming1 commented Jan 15, 2024

macos doesn't support direct IO.

macos doesn't support direct IO.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Copy link

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixes the problem. Resulting application works as well. Thanks!

@ming1 ming1 merged commit 0b4ef52 into main Jan 15, 2024
2 checks passed
@ming1 ming1 deleted the bug_fix branch March 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants