convert page_aligned_vec!() into Qcow2Iobuf #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
page_aligned_vec!() is like one hacky, and it may trigger STATUS_HEAP_CORRUPTION when running 'cargo test'. The reason is that windows with 'cargo test' requires Vec buffer to be freed with same alloc layout(alignment, size). Obviously, page_aligned_vec!() can be implemented in that way. Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Meta handling is the most tricky part wrt. using page_aligned_vec!(). Move Qcow2IoBuf object into Meta instance(L1, L2, RefTable, RefBlock) directly, and retrieve everything from this buffer. Turns out this way is simpler than before. Signed-off-by: Ming Lei <tom.leiming@gmail.com>
All conversions are straightforward. Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Now it is ready to setup windows CI since Qcow2IoBuf is used, and same alloc layout is used for both allocation and deallocation. Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert page_aligned_vec!() into Qcow2Iobuf, which is guaranteed that same alloc layout is used in both allocation
and deallocation,
this way fixes "(exit code: 0xc0000374, STATUS_HEAP_CORRUPTION)" when running
cargo testadd CI for covering windows build & test