-
Notifications
You must be signed in to change notification settings - Fork 437
Massive blocked iframe on some facebook sites #36
Comments
To me it looks like Fanboy is missing a filter to go with the other Facebook filters. Can you try: Looks like I will need a project list to fix Fanboy's annoyance and Fanboy Anti-Facebook until (and if) they add the missing filter. Other way to address this would be to also listen to attribute changes in the mutation observer, but this is something I am trying to avoid (overhead etc.) So I see the above filter as logically missing in the relevant filter list. Edit: updated to use a |
Ah nice, that does the trick. |
Just for the record, I don't think ABP would have suffered the same problem, because it listens to all load events, while uBlock listens only to the ones from elements which have not have their |
Submitted suggested fix to Fanboy's forum. |
Awesome -- thanks again. I love the focus on keeping uBlock's overhead incredibly low. I get the sense a lot of people avoid ABP & similar extensions due to CPU overhead on thin-ish clients like Chromeboxes (It's an ongoing problem we face with HTTPS Everywhere). |
Answer from fanboy:
Enabling Fanboy Anti-Facebook didn't work. Yet I see this filter in the list: |
Interesting, this issue allowed to uncover a nasty bug which affected filters using the |
Fixed in 0.2.3.2. |
Perhaps this is what's meant by the disclaimer for the anti-facebook list, but a number of sites that use <iframe> to embed facebook content end up with huge blocked icons (the iframe height & width are 1000px ea):
e.g. http://www.monoprice.com/Product?c_id=104&cp_id=10401&cs_id=1040115&p_id=9436&seq=1&format=2
I figured "Hide placeholders of blocked elements" would hide that enormous iframe, but it doesn't.
The text was updated successfully, but these errors were encountered: