Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sanoid spec file from dev repo, modified to not pull in build dependencies. #16

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

johnmmcgee
Copy link
Contributor

No description provided.

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should tweak the changelog? I'm not sure what the version would be since we don't want to get out of sync with the upstream release, but, would be good to reference our deps changes in the changelog.

@johnmmcgee
Copy link
Contributor Author

Think we should tweak the changelog? I'm not sure what the version would be since we don't want to get out of sync with the upstream release, but, would be good to reference our deps changes in the changelog.

I was just thinking that after i committed. I have updated.

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific versioning feedback in the related comments.

ucore/sanoid.spec Outdated Show resolved Hide resolved
ucore/sanoid.spec Outdated Show resolved Hide resolved
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple discrepancies in this spec file vs what sanoid docs recommend for CentOS. It gives me the feeling this spec is a bit neglected even in upstream.

I think it would be reasonable to update this spec to match the recommendations I've added as comments. If done, we can add those tweaks to the in-flight changelog entry as well.

Thoughts @johnmmcgee and @KyleGospo ?

I'm happy to help/do the tweaks if desired.

ucore/sanoid.spec Show resolved Hide resolved
ucore/sanoid.spec Show resolved Hide resolved
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's build this thing!

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I learned something from rpmlint
https://github.com/ublue-os/packages/actions/runs/8364177562/job/22899046010#step:4:52

We can't have a - hyphen in the version.

So I guess, please change -ucore1 to .ucore1.

@bsherman
Copy link
Contributor

OK! rpmlint fails, because of other spec files, but sanoid.spec is clean!

@bsherman bsherman merged commit b09041a into ublue-os:main Mar 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants