Add same offline charge animation as FP2. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flohack74
requested changes
Apr 10, 2019
| @@ -26,7 +26,7 @@ PRODUCT_COPY_FILES += \ | |||
| device/lge/hammerhead/init.hammerhead.rc:root/init.hammerhead.rc \ | |||
| device/lge/hammerhead/init.hammerhead.usb.rc:root/init.hammerhead.usb.rc \ | |||
| device/lge/hammerhead/fstab.hammerhead:root/fstab.hammerhead \ | |||
| device/lge/hammerhead/ueventd.hammerhead.rc:root/ueventd.hammerhead.rc | |||
| device/lge/hammerhead/ueventd.hammerhead.rc:root/ueventd.hammerhead.rc \ | |||
There was a problem hiding this comment.
Why there is a \ at the end but no other line following? I think thats a mistake.
| #device/lge/hammerhead/ubuntu_overlay/system/etc/mixer_paths.xml:system/ubuntu-overlay/system/etc/mixer_paths.xml \ | ||
| device/lge/hammerhead/ubuntu_overlay/system/usr/bin/hciattach:system/ubuntu-overlay/system/usr/bin/hciattach \ | ||
| device/lge/hammerhead/ubuntu_overlay/system/usr/share/bluetooth-touch/hammerhead:system/ubuntu-overlay/system/usr/share/bluetooth-touch/hammerhead | ||
|
|
There was a problem hiding this comment.
Your PR is named "charging animation" but here you also change a lot of the overlay stuff. This should not be part of the PR I think. Also, I think those files are already copied elsewhere, otherwise certain things would not work?
|
This was snuck in with #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now offline charging as the same animations as Fairphone 2