Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend vibration time for OPO #20

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Extend vibration time for OPO #20

merged 2 commits into from
Dec 22, 2019

Conversation

Flohack74
Copy link
Member

With that PR ubports/usensord#2 in place we can extend the vibration time in this upstart job so that OPO finally vibrates really on keyboard input :)

@Flohack74 Flohack74 added this to In progress in OTA-12 via automation Dec 20, 2019
@mariogrip
Copy link
Member

mariogrip commented Dec 21, 2019

I wonder, why dont we enable this on all devices? or are there a difference in the feeling on each devices?

Edit, i saw the comment on ubports/usensord#2, i understand now :)

Copy link
Member

@mariogrip mariogrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this an upstart override instead.

usensord.override with just:

env VIBRATE_SCALE=15

should work

@mariogrip mariogrip moved this from In progress to Review in progress in OTA-12 Dec 21, 2019
@Flohack74
Copy link
Member Author

Uh totally was too late, yes sure. I was not thinking that overlay in fact is "merged" into the conf, was thinking more of a replace way would happen ;)

@mariogrip mariogrip merged commit 1f2ffe4 into ubp-5.1 Dec 22, 2019
OTA-12 automation moved this from Review in progress to QA Dec 22, 2019
@mariogrip mariogrip deleted the extend-vibration-time branch December 22, 2019 04:22
Vince1171 added a commit to Vince1171/android_device_oneplus_oneplus3 that referenced this pull request Dec 23, 2019
Vince1171 added a commit to Halium/android_device_oneplus_oneplus3 that referenced this pull request Dec 24, 2019
@giiba
Copy link

giiba commented Dec 25, 2019

My OPO went from barely there to audibly aggressive. I feel VIBRATE_SCALE=15 is too much, and in some quick testing found a scale of 6 to be quite nice as far as the keyboard haptic effect.

@Flohack74
Copy link
Member Author

Flohack74 commented Dec 25, 2019

Well we can adjust this a bit, but there will be no real good solution for all users unless its configurable. You might want to add a feature request for that.
I have all core devices here, and you should compare the feel to N5, E5 or FP2, I personally think they are vibrating even more, and could need a tune down. But, I will try to get more feedback on that, and we keep this for final decisions before OTA ships ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
OTA-12
  
Done
3 participants