This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Add the alternate interface vendor.qti.qcril.am #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you've messed up the commit information on these. Could you rewrite the commits to fix that? |
Flohack74
force-pushed
the
xenial_-_alternate-qti-interface
branch
from
8f888b0
to
4e66fe0
Compare
|
@UniversalSuperBox yeah its not ready to be merged. What do you mean exactly? |
Flohack74
force-pushed
the
xenial_-_alternate-qti-interface
branch
from
4e66fe0
to
cb18eee
Compare
|
The commits have no authorship information, or the information that's there is incorrect. But if you don't want this reviewed, please mark it as a draft. I'm going through all open PRs right now! |
Flohack74
changed the title
Flohack74
force-pushed
the
xenial_-_alternate-qti-interface
branch
3 times, most recently
from
9fd1dc3
to
6b0c453
Compare
…g different interface names
Flohack74
force-pushed
the
xenial_-_alternate-qti-interface
branch
from
6b0c453
to
097be97
Compare
Flohack74
changed the title
|
So it matured quickly, ready for review ^^ |
Flohack74
pushed a commit
that referenced
this pull request
May 26, 2021
Add dummy hw2_0 implementation.
(cherry picked from commit 7e5d70e)
|
looks good |
|
Note that I proposed this to upstream as well in mer-hybris#6 - whenever that gets merged I will take care of resolving the conflict and accept the upstream version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thats necessary because some devices use a vendor service called differently to do the job.