Packaging review

.bzr-builddeb/default.conf

@@ -0,0 +1,2 @@
+[BUILDDEB]
+split = True

debian/changelog

@@ -1,5 +1,10 @@
-dialer-app (0.1) UNRELEASED; urgency=low
+dialer-app (0.1-0ubuntu1) UNRELEASED; urgency=low
 
+  [ Tiago Salem Herrmann ]
   * Initial release
 
+  [ Łukasz 'sil2100' Zemczak ]
+  * Modifications related to compliance with our packaging standards
+  * Automatic snapshot from revision 20 (bootstrap)
+
  -- Tiago Salem Herrmann <tiago.herrmann@canonical.com>  Mon, 15 Jul 2013 11:36:03 -0300

debian/control

@@ -14,51 +14,42 @@ Build-Depends: cmake,
                qtbase5-dev (>= 5.0),
                qtdeclarative5-dev (>= 5.0),
 Standards-Version: 3.9.4
-Vcs-Bzr: lp:dialer-app
+Homepage: https://launchpad.net/dialer-app
+# If you aren't a member of ~phablet-team but need to upload packaging changes,
+# just go ahead.  ~phablet-team will notice and sync up the code again.
+Vcs-Bzr: https://code.launchpad.net/~phablet-team/dialer-app/trunk
 Vcs-Browser: https://bazaar.launchpad.net/~phablet-team/dialer-app/trunk/files
 
 Package: dialer-app
-Architecture: i386 amd64 armhf
+Architecture: any
 Depends: ${misc:Depends},
          ${shlibs:Depends},
          dbus-x11,
-         libicu48,
          qtdeclarative5-ubuntu-history-plugin,
          qtdeclarative5-ubuntu-telephony-plugin,
-         qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu
+         qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
 Recommends: unity8 (>= 7.81.0~),
 Description: Dialer application for Ubuntu
  An application to make phone calls
 
-Package: dialer-app-dbg
-Architecture: i386 amd64 armhf
-Section: debug
-Priority: extra
-Depends: ${misc:Depends},
-         dialer-app (= ${binary:Version}),
-Description: debugging symbols for dialer-app
- This package contains the debugging symbols for dialer-app
-
 Package: dialer-app-autopilot
 Architecture: all
 Section: debug
-Priority: extra
 Depends: ${misc:Depends},
          autopilot-qt5,
          libqt5test5,
          libqt5widgets5,
          dialer-app (>= ${binary:Version}),
-         python-autopilot
+         python-autopilot,
 Description: autopilot tests for dialer-app
  This package contains the autopilot tests for dialer-app
 
 Package: dialer-app-connected-autopilot
 Architecture: all
 Section: debug
-Priority: extra
 Depends: ${misc:Depends},
-         dialer-app (= ${binary:Version}),
+         dialer-app (>= ${binary:Version}),
          libautopilot-qt,
-         python-autopilot
+         python-autopilot,
 Description: connected autopilot tests for dialer-app
  This package contains the connected autopilot tests for dialer-app

debian/copyright

@@ -1,9 +1,15 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: dialer-app
+Source: https://launchpad.net/dialer-app
 
 Files: *
 Copyright: 2012, 2013 Canonical Ltd.
 License: GPL-3
 
+Files: src/qml/assets/*
+Copyright: 2012, 2013 Canonical Ltd.
+License: CC-BY-SA-3.0
+
 License: GPL-3
  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
@@ -20,3 +26,8 @@ License: GPL-3
  On Debian systems, the full text of the GNU General Public License
  version 3 can be found in the file /usr/share/common-licenses/GPL-3.
 
+License: CC-BY-SA-3.0
+ This work is licensed under the Creative Commons Attribution-ShareAlike 3.0
+ Unported License. To view a copy of this license, visit
+ http://creativecommons.org/licenses/by-sa/3.0/ or send a letter to Creative
+ Commons, 444 Castro Street, Suite 900, Mountain View, California, 94041, USA.

debian/rules

@@ -4,11 +4,10 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-override_dh_install:
-	dh_install --fail-missing
+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
 
 %:
-	dh $@ --parallel --with translations
+	dh $@ --parallel --fail-missing --with translations
 
 override_dh_auto_configure:
 	dh_auto_configure -- -DCMAKE_BUILD_TYPE=Debug
@@ -21,7 +20,3 @@ override_dh_translations:
 	# Unfortunately, the default build directory is not exposed
 	# (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601774).
 	$(MAKE) -C obj-$(DEB_HOST_GNU_TYPE) dialer-app.pot
-
-.PHONY: override_dh_strip
-override_dh_strip:
-	dh_strip --dbg-package=dialer-app-dbg