Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneplus 2/3/3T: add/improve LineageOS/OxygenOS support #86

Closed
wants to merge 0 commits into from

Conversation

Vince1171
Copy link
Member

OnePlus 2:

  • Use the new LineageOS plugin
  • Add OxygenOS 3.6.1 support

OnePlus 3/3T:

  • Add LineageOS support using the new plugin

DO NOT MERGE without #85 and ubports/ubports-installer#1834

@NeoTheThird
Copy link
Member

is there a problem with opengapps? or why the removal

@Vince1171
Copy link
Member Author

is there a problem with opengapps? or why the removal

because it was a "static" install (download a specific .zip and ask the user to install it via sideload) and it's not compatible with an ORS install. I could use ORS to install a specific OpenGapps .zip too...

But I'll just finish the OpenGapps plugin and make the installation process properly ( latest version of openGapps etc... ) ^^

btw do you know if it's possible to display an option only under certain conditions? Or I just open a new feature request? ;)
something like:

options:
      - var: "opengapps"
        name: "Install OpenGapps"
        type: "boolean"
        value: false
      - var: "opengappsChannel"
        name: "OpenGapps Channel"
        tooltip: "Do you want to install pico nano micro mini full version of OpenGapps?"
        link: "https://opengapps.org/"
        type: "select"
        remote_values:
          opengapps:channels:
        condition:
          var: "opengapps"
          value: true

@NeoTheThird
Copy link
Member

But I'll just finish the OpenGapps plugin and make the installation process properly ( latest version of openGapps etc... ) ^^

Ahh, ok. Great!

btw do you know if it's possible to display an option only under certain conditions? Or I just open a new feature request? ;)

Nope, that's not a thing yet. Funny, we talked about the same thing for postmarketos just yesterday. Opened #87 to track this.

Copy link
Member

@NeoTheThird NeoTheThird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin' good! can be merged as soon as the plugin is live. thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants