Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Keyboard help desactivated when switching french-swiss keyboard to emoji and back to french-swiss keyboard #100

Closed
wilfridd opened this issue Oct 12, 2019 · 21 comments · Fixed by #134
Projects

Comments

@wilfridd
Copy link

Little annoying bug found. Tested with app "Notes" or "Teleports" on N5, MX4

Steps to reproduce

  1. Display language is "English UK"
  2. Enable 3 keyboard layouts : EN, FR-CH, EMOJI
  3. Spell checking, auto Capitalization, auto Punctuation are set to ON.

With the "earth symbol", select FR-CH -> word suggestion bar is visible:

  • Start typing ".", then "space" -> keyboard is uppercase automatically
  • Type "F", then "space" 2 times -> "." appears automatically

Select EMOJI -> word suggestion bar is not visible (that's ok)

  • type some emoji

Select FR-CH -> word suggestion bar is NOT visible (weird)

  • Start typing ".", then "space" -> keyboard is NOT uppercase automatically
  • Type "F", then "space" 2 times -> "." does NOT appears automatically

Select EN, word suggestion bar is visible again, auto Cap and auto Punct work again
Select FR-CH, word suggestion bar is visible again, auto Cap and auto Punct work again
Then loop to "select EMOJI" to continue reproducing...

Expected behavior
Switch from FR-CH to EMOJI
Type some EMOJI
Switch back to FR-CH, word suggestion bar is still visible , auto Capitalization, auto Punctuation work

Actual behavior
Word suggestion bar, auto Cap and auto Punct are disabled when switching from FR-CH to EMOJI and back to FR-CH
Switching OFF/ON Word suggestion bar, auto Cap and auto Punct in "Language & Text" setting has no effect.
Switch to EN and back to FR-CH makes Word suggestion bar, auto Cap and auto Punct work again.

BR
wilfridd

@Fuseteam
Copy link
Contributor

The same behavior is present on the dvorak layout and the layout in pr #93

preliminary testing seems to reveal that it adopts the dictionary of the previously selected layout
it just so happens that the emoji layout doesn't have a dictionary

@Fuseteam
Copy link
Contributor

Fuseteam commented Dec 3, 2019

looking at maliit-server.log it appears these lines looks relevant

CRITICAL: Couldn't find word engine plugin for  "fr-ch"
CRITICAL: Couldn't find word engine plugin for  "en@flick"
CRITICAL: Couldn't find word engine plugin for  "en@dv"

@Fuseteam
Copy link
Contributor

WARNING: void MIMPluginManagerPrivate::_q_setActiveSubView(const QString&, Maliit::HandlerState) "libubuntu-keyboard-plugin.so" "en@flick" is not enabled
could possibly be the cause

@Fuseteam
Copy link
Contributor

Fuseteam commented Feb 20, 2020

aha! this function tries to load "fr-ch" or "en@dv" or "en@flick" while it should just load "fr" and "en"

if all language dictionaries have 2 letter codes we could just truncate it at 2 variables in here

Fuseteam added a commit to Fuseteam/keyboard-component that referenced this issue Feb 20, 2020
@wilfridd
Copy link
Author

Hi Fuseteam,
thank you!
how can test your change? thanks for guidance.
BR
Wilfridd

@Fuseteam
Copy link
Contributor

@wilfridd i am testing a fix(es) on the flick branch since that experiences the same issue but so far no dice

@Fuseteam
Copy link
Contributor

Fuseteam commented Apr 30, 2020

hey @wilfridd i finally found a workaround
if you want you can test it by installing pr 128, You'll need to set rootfs to read write, even if temporary, via ut tweak tool

here are the steps

  1. sudo ubports-qa install ubports/keyboard-component 128
    note: ubports-qa should fail, if it doesn't select "no" when prompted
  2. sudo apt install ubuntu-keyboard-english-flick
  3. restart maliit-server

tapping and holding on your symbol key should reveal a new a way to access emoji by "flicking".

note you don't have tap and hold to select the emoji keyboard

it's somewhat experimental so there are some bugs i have yet to work out feel free to list any you find on pr 128

@Fuseteam
Copy link
Contributor

Fuseteam commented May 1, 2020

@wilfridd disregard my previous comment pr 128 is no longer a viable workaround, the idea was scrapped before it could see the light of day

@wilfridd
Copy link
Author

wilfridd commented May 1, 2020

ok.
In the meantime, I've found this workaround:
I switch to french or english KB then back to fr_ch and KB helpers are back with world suggestion too...
BR
w.

@Fuseteam
Copy link
Contributor

hi @wilfridd can you test the about pull request to see if it works for you?

@wilfridd
Copy link
Author

Hi @Fuseteam
PR 134. All keybord helpers work on Meizu4 with swiss french layout (devel)
Will test on N5 next.
That's nice!! Thank you!!
W.

@wilfridd
Copy link
Author

Hi @Fuseteam,
It works also on N5

@Fuseteam
Copy link
Contributor

awesome glad to hear @wilfridd would mind adding your finding to the pr?

@wilfridd wilfridd closed this as completed Jan 3, 2021
@wilfridd
Copy link
Author

wilfridd commented Jan 3, 2021

keyboard helpers fixed with swiss french layout
Thanks!

@lduboeuf
Copy link
Contributor

lduboeuf commented Jan 3, 2021

@wilfridd since the PR is not merged yet, can you reopen that issue ? Will be auto closed when PR is merged

@wilfridd wilfridd reopened this Jan 4, 2021
@wilfridd
Copy link
Author

wilfridd commented Jan 4, 2021

Hi @lduboeuf , issue reopened as requested.
w.

@Flohack74 Flohack74 added this to Nice to Have in OTA-16 via automation Jan 31, 2021
@Flohack74 Flohack74 moved this from Nice to Have to In Progress in OTA-16 Jan 31, 2021
@wilfridd
Copy link
Author

Hi @lduboeuf , @Flohack74,
Currently testing on N5 with new fresh install RC (2021-W07). "Nice to have" means not in RC ?
I had to do a ubports-qa install ubports/keyboard-component 134 to have the fix.
I confirm the fix is working fine.
Should I test something else to have it promoted to RC and next stable?
W.

@lduboeuf
Copy link
Contributor

Hi @lduboeuf , @Flohack74,
Currently testing on N5 with new fresh install RC (2021-W07). "Nice to have" means not in RC ?
I had to do a ubports-qa install ubports/keyboard-component 134 to have the fix.
I confirm the fix is working fine.
Should I test something else to have it promoted to RC and next stable?
W.

Unfortunatly, this won't go on OTA-16 as it is feature-freezed now. Let see for next upgrade hopefully. cc @UniversalSuperBox ;-)

@mariogrip mariogrip removed this from In Progress in OTA-16 Feb 22, 2021
@mariogrip mariogrip added this to To do in OTA-17 via automation Feb 22, 2021
OTA-17 automation moved this from To do to QA Mar 24, 2021
@Fuseteam
Copy link
Contributor

awesome this fixed a blocking issue with flick as well

@lduboeuf
Copy link
Contributor

awesome this fixed a blocking issue with flick as well

which issue ?

@Fuseteam
Copy link
Contributor

awesome this fixed a blocking issue with flick as well

which issue ?

the same issue :) it is fixed now 👍

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-17 May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants