Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Update Keyboard Polish #84

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Update Keyboard Polish #84

merged 4 commits into from
Aug 22, 2019

Conversation

Daniel20000522
Copy link
Contributor

No description provided.

Copy link
Member

@Flohack74 Flohack74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing so many keybindings?

@Daniel20000522
Copy link
Contributor Author

These characters are not used in Polish.

@Flohack74
Copy link
Member

Can you send me a screenshot of a polish keyboard? I need to make sure we are doing the right thing.

@Daniel20000522
Copy link
Contributor Author

screenshot20190822_233020698
screenshot20190822_233033102
screenshot20190822_233035968

@Flohack74
Copy link
Member

I meant a screenshot of a real physical keyboard ;)

@Daniel20000522
Copy link
Contributor Author

image20190822_233718563

@Daniel20000522
Copy link
Contributor Author

We use such diacritical marks: ą, ć, ę, ł, ń, ó, ś, ź, ż

@Flohack74
Copy link
Member

I see here: http://ascii-table.com/keyboard.php/457
So basically looks good, but if some Polish guys complain you have to fix it again. I can´t judge if this is 100% correct.

@Daniel20000522
Copy link
Contributor Author

OK no problem.

@Flohack74 Flohack74 merged commit 2b8cb7b into ubports:xenial Aug 22, 2019
@advocatux
Copy link

Maybe this is a silly question (sorry) but is it somewhat possible that these changes are causing this issue https://github.com/ubports/ubuntu-touch/issues/1204? Thank you!

@Daniel20000522
Copy link
Contributor Author

It is possible that this is a problem. I will revert the changes and see what happens.

@advocatux
Copy link

@Daniel20000522 just for the record, the Polish keyboard update affected that issue indirectly but the real culprit it seems it was how the apt pinning priorities were set.

See ubports/livecd-rootfs#7 (comment) for details.

Thank you for your work !!

@UniversalSuperBox
Copy link
Member

Hi @Daniel20000522,

Would you like a name other than Daniel20000522 posted in the OTA-11 Call for Testing and Release blog post in the Changelog section? (for example: the end of https://ubports.com/blog/ubports-blog-1/post/ubuntu-touch-ota-10-release-239)

@Daniel20000522
Copy link
Contributor Author

It can be the nick Daniel20000522. Thanks

@UniversalSuperBox
Copy link
Member

Excellent, thank you. Huge thanks for the help!

@UniversalSuperBox
Copy link
Member

Notes for QA:

The Polish keyboard has been changed to only include diacritics useful for the language. If you use this keyboard, please ensure that no characters you need have been removed.

@UniversalSuperBox UniversalSuperBox added this to In progress in OTA-11 via automation Sep 27, 2019
@UniversalSuperBox UniversalSuperBox moved this from In progress to QA in OTA-11 Sep 27, 2019
@Daniel20000522
Copy link
Contributor Author

Everything is OK. Thanks

@ziggutas
Copy link

Devices: Nexus 7 (flo), BQ E4.5 ubuntu edition. Both on rc (2019-W42)
On these two devices the Polish keyboard displays diacritical marks: ą, ć, ę, ł, ń, ó, ś, ź, ż.
There is no accent for d

@Daniel20000522
Copy link
Contributor Author

What accent are you missing: ď, đ
These 2 marks do not belong to Polish diacritical marks so they have been removed.

@ziggutas
Copy link

OK, I understand.
I don't know Polish so I was using the phone screenshots posted above as my point of reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
OTA-11
  
QA
Development

Successfully merging this pull request may close these issues.

None yet

5 participants