Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Update Messages.qml #79

Merged
merged 2 commits into from Mar 11, 2019
Merged

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Mar 4, 2019

Removed MultiRecepient field's right margin.
Fixes #47

Removed MultiRecepient field's right margin.
@krille-chan
Copy link
Collaborator

LGTM 👍
Thank you very much for your contribution. I have found another design bug for this header:

screenshot20190307_154314434

This seems to be fixed, when we set the topMargin to:
topMargin: parent ? (parent.height - multiRecipient.height)/2 : units.gu(1)

If you agree, would you add this patch to your Pull Request so we can have this fixed in one step?
fix-topMargin.patch.txt

Fix issue when sometimes the multi recipient field makes contact with the bottom of the header.
@kugiigi
Copy link
Contributor Author

kugiigi commented Mar 10, 2019

Done. And I also tested it on my Nexus 5 where I replicated it.

@Flohack74 Flohack74 merged commit 5008aae into ubports:xenial Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants