Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Messages.qml #79

Merged
merged 2 commits into from Mar 11, 2019

Conversation

@kugiigi
Copy link
Contributor

commented Mar 4, 2019

Removed MultiRecepient field's right margin.
Fixes #47

Update Messages.qml
Removed MultiRecepient field's right margin.
@ChristianPauly

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

LGTM 👍
Thank you very much for your contribution. I have found another design bug for this header:

screenshot20190307_154314434

This seems to be fixed, when we set the topMargin to:
topMargin: parent ? (parent.height - multiRecipient.height)/2 : units.gu(1)

If you agree, would you add this patch to your Pull Request so we can have this fixed in one step?
fix-topMargin.patch.txt

Update Messages.qml
Fix issue when sometimes the multi recipient field makes contact with the bottom of the header.
@kugiigi

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Done. And I also tested it on my Nexus 5 where I replicated it.

@Flohack74 Flohack74 merged commit 5008aae into ubports:xenial Mar 11, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.