Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Fix SMS counter #88

Merged
merged 1 commit into from Apr 8, 2019
Merged

Fix SMS counter #88

merged 1 commit into from Apr 8, 2019

Conversation

krille-chan
Copy link
Collaborator

screenshot20190405_154308539

@Flohack74 Flohack74 merged commit 46f8cd7 into xenial Apr 8, 2019
@Flohack74 Flohack74 deleted the smscounter branch April 8, 2019 07:52
@UniversalSuperBox UniversalSuperBox added this to In progress in OTA-9 via automation Apr 18, 2019
@UniversalSuperBox UniversalSuperBox moved this from In progress to QA in OTA-9 Apr 18, 2019
@Danfro
Copy link

Danfro commented May 1, 2019

Testing on E5 with RC 2019-W18.

Counter does appear at 10 chars before the end of the first SMS. 👍

@jezek
Copy link
Contributor

jezek commented May 5, 2019

FP2 (2019-W18)

Counter does appear at 10 chars before the end of the first SMS.

@ziggutas
Copy link

ziggutas commented May 6, 2019

BQ E4.5 rc (2019-W18)
Cannot see a message counter despite repeated attempts at composing a message.

@krille-chan
Copy link
Collaborator Author

BQ E4.5 rc (2019-W18)
Cannot see a message counter despite repeated attempts at composing a message.

The counter appears at 10 chars before the end of the first SMS. Have you tried to write more characters?

@ziggutas
Copy link

ziggutas commented May 7, 2019

I write about 3 lines of text and nothing appears.
Continue message, add emojis and on about the 10th emoji a number such as '10/1' may appear.
No bracketed number as in your screenshot example above.
Another test writing 1.5 lines text followed by emojis needed 19 emojis before anything showed under text box.

@krille-chan
Copy link
Collaborator Author

The behaviour changed in latest merge request. Only when there are 10 characters left for 1 sms, it is visible. That's the same behaviour like on the android sms app.

@ziggutas
Copy link

ziggutas commented May 7, 2019

Ahhh, I hadn't grasped exactly what this issue was, excuse my confusion
!!
BQ E4.5 works fine.
Counter appears for last 10 characters of first message and then changes to '145/2', presumably counting down for the second message.
And I now notice emojis are equivalent to 5 characters, I think.
Nifty.

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-9 May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
OTA-9
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants