Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the caller parameter (this) to the PopupUtils.show(...) calls #173

Merged
merged 3 commits into from Apr 8, 2019

Conversation

@balcy
Copy link
Collaborator

commented Mar 30, 2019

use theme.palette.normal.foreground for the SavePageDialog buttons

fixes #167
fixes #158
fixes #156

balcy added some commits Mar 30, 2019

add the caller parameter (this) to the PopupUtils.show(...) calls
use theme.palette.normal.foreground for the SavePageDialog buttons

@UniversalSuperBox UniversalSuperBox self-requested a review Apr 4, 2019

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Most everything here checks out to me. Dialogs open on the proper window and there are some fancy new icons.

If you don't mind, I'd like your opinion on this @cibersheep. The colors on this dialog have changed:

image

@balcy

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 8, 2019

see the linked issues...

@cibersheep

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

That's correct. Those are the «neutral colors» as in the guidelines.
I suggest go with them and find a better looking ones :) together, as they got outdated

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Sorry, can't read.

@UniversalSuperBox UniversalSuperBox merged commit abba60f into ubports:xenial Apr 8, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@balcy balcy deleted the balcy:xenial_-_popuputils branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.