Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Remove the DDG search with canonical string #250

Closed
wants to merge 2 commits into from
Closed

Remove the DDG search with canonical string #250

wants to merge 2 commits into from

Conversation

Aury88
Copy link
Contributor

@Aury88 Aury88 commented Nov 1, 2019

Removed the DuckDuckGo search engine that adds the "t=canonical" string to the searches. this could lead to misunderstanding or (wrong) inference like this https://forums.ubports.com/topic/3309/morph-browser-explanation-about-canonical-in-url
also ubports is indipendent from canonical so this could lead to wrong statistic analisys about ubuntu diffusion (with accusations of inflating data) and biases about ubports project and its indipendence. use instead the duckduckgo-html-only.xml (renamed duckduckgo.xml)

Removed the DuckDuckGo search engine that adds the "t=canonical" string to the searches. this could lead to misunderstanding or (wrong) inference like this https://forums.ubports.com/topic/3309/morph-browser-explanation-about-canonical-in-url
also ubports is indipendent from canonical so this could lead to wrong statistic analisys about ubuntu diffusion (with accusations of inflating data) and biases about ubports project and its indipendence. use instead the duckduckgo-html-only.xml
renamed after removing the duckduckgo.xml that add the canonical string in the search
@Aury88 Aury88 marked this pull request as ready for review November 1, 2019 10:47
@balcy
Copy link
Collaborator

balcy commented Nov 1, 2019

yeah I've noticed that "canonical" too.
But why not keeping both duckduckgo (without the t=canonical) and "duckduckgo html only" ?

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search engine can stay, but removing the 'canonical' tag should be fine.

@Aury88
Copy link
Contributor Author

Aury88 commented Nov 1, 2019

see commit #251(don't know how to revert in a PR)

@Aury88 Aury88 closed this Nov 1, 2019
@Aury88 Aury88 deleted the patch-1 branch November 1, 2019 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants