Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serve docs on GitHub Pages #75

Open
NeoTheThird opened this issue Nov 2, 2022 · 4 comments
Open

serve docs on GitHub Pages #75

NeoTheThird opened this issue Nov 2, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@NeoTheThird
Copy link
Member

Docs should be available online!
@NeoTheThird NeoTheThird added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Nov 2, 2022
@strazzere
Copy link
Contributor

I will gladly take this on for you, especially since almost all of it is done already (doc generation and such). Would you prefer to make me a maintainer so I can make the setting changes? Or would you prefer a demo in my own fork and then a PR with instruction for a maintainer?

@NeoTheThird
Copy link
Member Author

Demo would be great, if it's not too much work!

@strazzere strazzere mentioned this issue Nov 8, 2022
Merged
@strazzere
Copy link
Contributor

This can be closed now, I think because I am not a maintainer the PR linkage didn't auto close it.

@strazzere
Copy link
Contributor

Actually upon doing some more digging, it looks like the gh-pages publish should only occur after a push to master. Currently it will run on any open PR and fail (which arguably is good since that would be a security concern?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@strazzere @NeoTheThird