Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme detection #13

Merged
merged 3 commits into from Mar 12, 2019

Conversation

@bhdouglass
Copy link
Member

commented Mar 10, 2019

Detect the dark theme being set in the ubuntu touch uitk's config file. Also added a clickable setup to make it easier to test on the device.

bhdouglass added some commits Feb 22, 2019

@bhdouglass bhdouglass requested a review from cibersheep Mar 10, 2019

@cibersheep

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

I can test the PR tomorrow (I think)

@cibersheep

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

@bhdouglass do you need to check the building error before merging?

@bhdouglass bhdouglass changed the base branch from master to xenial Mar 11, 2019

@bhdouglass

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

This PR was made against the master branch rather than the xenial branch, not sure if that caused this issue. @UniversalSuperBox how can I restart the ci checks?

@bhdouglass

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Merging this in despite failing checks, since it works on my other PR based on this branch.

@bhdouglass bhdouglass merged commit a829d0d into xenial Mar 12, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
continuous-integration/jenkins/branch This commit looks good
Details

@bhdouglass bhdouglass deleted the xenial_-_dark-theme-detection branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.