This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Reauthentication #14
Merged
Reauthentication #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error with the "itemsChanged()" signal connection:
[8/19/19 4:35 PM] QObject::connect: Cannot queue arguments of type
'QList<QOrganizerItemDetail::DetailType>'
(Make sure 'QList<QOrganizerItemDetail::DetailType>' is registered using
qRegisterMetaType().)
With the migration to the new QtPim library, the look-up of an EDS source from a collection ID got broken. We now restore it, so that when a calendar is locally modified, a sync is queued up.
Don't always retry on authentication errors, but only if the network went offline.
UniversalSuperBox
suggested changes
Aug 21, 2019
Me too, but unfortunately the project is not setup for functional testing; adding them would require an amount of time which I don't have. :-( I'd recommend merging this when the next OTA is still far, so we have plenty of time to test it and fix it if needed. In my tests it performs well, and it actually fixes an actual bug where a sync was not scheduled if the calendar was modified locally. |
UniversalSuperBox
approved these changes
Sep 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be easier to review this commit by commit.