Fix papercuts in sync-monitor #15
Conversation
There was a problem hiding this comment.
In the first commit you are removing one screenshot and adding another one. But it seems that the same screenshots are being added in the commit where you add the README; can you remove these changes from the first commit, then (git reset should help in taking them out of the staged changes)?
| QTimer::singleShot(1000, daemon, SLOT(syncAll())); | ||
| // We need to wait a little bit so we realize that we're connected to | ||
| // the internet | ||
| qDebug() << "Starting manual sync in 10 seconds."; |
There was a problem hiding this comment.
Isn't 10 seconds too much, though? In theory, the time needed to get the network status is the time of making a D-Bus call, so even one second should be enough.
There was a problem hiding this comment.
No, getting the network status can take quite a while. 1 second was not enough.
|
I uploaded the screenshots twice so that they were correct at that commit. The examples in "Add a README" are correct for the code as it is at that commit. The examples in "Correct grammar and spelling" are correct for that commit. |
UniversalSuperBox
force-pushed
the
xenial_-_sync-monitor-papercuts
branch
from
58c5908
to
98568aa
Compare
dh-translations does not have a Multi-Arch value in xenial, so it can't be resolved for crossbuilding.
UniversalSuperBox
force-pushed
the
xenial_-_sync-monitor-papercuts
branch
from
98568aa
to
5fb1783
Compare
|
Okay, squashed the README and grammar commits together and rebased on |
Fix the
--synccommand, fix building with Crossbuilder, add a README, and fix up the grammar and spelling all over the place. Just some papercuts that need to be cleaned up so more contributions can happen.These commits are mostly atomic, please rebase and merge.