Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[click] Update to use openstore v3 api #151

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@mariogrip
Copy link
Member

commented Apr 24, 2019

No description provided.

@mariogrip mariogrip marked this pull request as ready for review Apr 24, 2019

@mariogrip

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

seems to work fine for me

@mariogrip mariogrip requested review from mardy and UniversalSuperBox and removed request for mardy Apr 24, 2019

@mariogrip mariogrip changed the title [click] Inital stab at updating to v3 api [click] Update to use openstore v3 api Apr 24, 2019

@mariogrip mariogrip force-pushed the xenial_-_update-v3 branch from 6a8f680 to 47bc488 Apr 24, 2019

@mardy
Copy link
Member

left a comment

Just a couple of minor remarks. I still have to test it, will do that very soon :-)

plugins/system-update/click/apiclient_impl.cpp Outdated Show resolved Hide resolved
plugins/system-update/click/apiclient_impl.cpp Outdated Show resolved Hide resolved

@mariogrip mariogrip force-pushed the xenial_-_update-v3 branch from 47bc488 to 015a4c8 Apr 24, 2019

@mardy

mardy approved these changes Apr 24, 2019

Copy link
Member

left a comment

Works like a charm!

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Don't forget translations!

@UniversalSuperBox
Copy link
Member

left a comment

Eh, never mind. I'll just pull them in to #149

@mariogrip mariogrip merged commit 2448cbb into xenial Apr 24, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@mariogrip mariogrip deleted the xenial_-_update-v3 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.