Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

[click] Update to use openstore v3 api #151

Merged
merged 2 commits into from Apr 24, 2019
Merged

Conversation

mariogrip
Copy link
Member

No description provided.

@mariogrip mariogrip marked this pull request as ready for review April 24, 2019 18:57
@mariogrip
Copy link
Member Author

seems to work fine for me

@mariogrip mariogrip requested review from mardy and UniversalSuperBox and removed request for mardy April 24, 2019 18:57
@mariogrip mariogrip changed the title [click] Inital stab at updating to v3 api [click] Update to use openstore v3 api Apr 24, 2019
Copy link
Member

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor remarks. I still have to test it, will do that very soon :-)

plugins/system-update/click/apiclient_impl.cpp Outdated Show resolved Hide resolved
plugins/system-update/click/apiclient_impl.cpp Outdated Show resolved Hide resolved
Copy link
Member

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@UniversalSuperBox
Copy link
Member

Don't forget translations!

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, never mind. I'll just pull them in to #149

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants