Always show launcher settings and some changes #269
Conversation
| @@ -62,7 +65,7 @@ ItemPage { | |||
| spacing: units.gu(1) | |||
|
|
|||
| SettingsItemTitle { | |||
| text: i18n.tr("On large screens:") | |||
| text: i18n.tr("On desktop mode:") | |||
There was a problem hiding this comment.
Does the text here really need to be changed? If so, I think we can also choose better wording for this. But I don't think it needs to be changed.
There was a problem hiding this comment.
It's not necessary to change but I feel like On large screens does not describe accurately when the settings take effect. I mean even in large screens, the launcher is always hidden when in staged mode. In desktop mode, the setting takes effect in certainty. Or maybe Windowed mode is a better term?
There was a problem hiding this comment.
I went back and re-read this topic and I think I'm going to stand with the words I used. Desktop mode is the official term used in Lomiri as displayed in the indicators. The option to always show the launcher only takes effect on desktop mode and not necessarily on large screens 😄
There was a problem hiding this comment.
I think we should change the text in the indicator too then, not use "desktop" everywhere. Instead we should call it windowed mode.
There was a problem hiding this comment.
I would actually agree with that. Windowed mode describes it better then maybe in the future, tiling mode too :)
|
Hello, Thank you for your contribution to system-settings. We have now moved this repository to GitLab to take advantage of better issue tracking and CI capabilities. Things are going to be a little crazy for this repository between now and the release of Ubuntu Touch based on 20.04, but here's what you need to know:
If you have any questions, please comment on the MR that GitLab created for you. We'll try our best to answer. |
recreation of #235 for better commits