Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Use workaround for displayname not localename. #56

Closed
wants to merge 3 commits into from
Closed

Use workaround for displayname not localename. #56

wants to merge 3 commits into from

Conversation

dobey
Copy link
Member

@dobey dobey commented May 17, 2018

Only use the workaround of using pt_pt to solve the display name
issue, and not set the actual locale to pt_PT (which doesn't exist
on disk in the langpack, as it's only pt or pt_BR).

dobey added 3 commits May 17, 2018 15:06
Only use the workaround of using pt_pt to solve the display name
issue, and not set the actual locale to pt_PT (which doesn't exist
on disk in the langpack, as it's only pt or pt_BR).
Copy link
Member

@mariogrip mariogrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dobey
Copy link
Member Author

dobey commented May 18, 2018

I think @UniversalSuperBox was having some issues with it still, in that plain pt was not showing up in the list for some reason, with this change. So please don't merge yet. :)

@UniversalSuperBox
Copy link
Member

Just to put it on the record, this will (eventually) fix ubports/ubuntu-touch#510

@Flohack74
Copy link
Member

Is this ready to merge?

@dobey
Copy link
Member Author

dobey commented May 21, 2018

@Flohack74 I guess not. It seems plain Portuguese gets removed from the list with this change for some reason. :-/

@UniversalSuperBox
Copy link
Member

The reason we haven't been able to add the pt locale (which we expect to be pt_PT) is because Qt has a set of likely locales for each language (for example, you get en_US when you select en). For pt it's pt_BR rather than pt_PT, so we need to keep the workaround in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants