This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
mir/agent: fix indefinite wait if fail to start prompt session #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peat-psuwit
force-pushed
the
xenial_-_handle-prompt-fails-to-start
branch
from
79721f8
to
f6a7484
Compare
For some reason, Mir still provide an FD for a prompt session even if it fails to start. When this FD is passed to the prompt provider, it will just hang, causing the whole trust store user chain to just wait. To fix this, make sure the agent checks for the error before continue. Related: ubports/ubuntu-touch#1668
peat-psuwit
force-pushed
the
xenial_-_handle-prompt-fails-to-start
branch
from
f6a7484
to
25d3d82
Compare
UniversalSuperBox
approved these changes
Feb 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, Mir still provide an FD for a prompt session even if it
fails to start. When this FD is passed to the prompt provider, it will
just hang, causing the whole trust store user chain to just wait. To fix
this, make sure the agent checks for the error before continue.
Related: ubports/ubuntu-touch#1668